[pve-devel] [PATCH pve-manager] ext6migrate: last fixes for firewall

Emmanuel Kasper e.kasper at proxmox.com
Mon Feb 8 14:29:54 CET 2016


listen to 'activate' event is needed because of framework changes,
similar to 66162fe4a96ddc8c42c61b6d4cf41edda68210af

ext6migrate: listen to 'activate' events for panels inside a tabpanel
---
 www/manager6/form/FirewallPolicySelector.js | 13 +++----------
 www/manager6/grid/FirewallOptions.js        |  4 ++--
 2 files changed, 5 insertions(+), 12 deletions(-)

diff --git a/www/manager6/form/FirewallPolicySelector.js b/www/manager6/form/FirewallPolicySelector.js
index 81492a6..05eea90 100644
--- a/www/manager6/form/FirewallPolicySelector.js
+++ b/www/manager6/form/FirewallPolicySelector.js
@@ -1,16 +1,9 @@
 Ext.define('PVE.form.FirewallPolicySelector', {
     extend: 'PVE.form.KVComboBox',
     alias: ['widget.pveFirewallPolicySelector'],
-  
-    initComponent: function() {
-	var me = this;
-
-	me.data = [ 
-	    ['ACCEPT', 'ACCEPT'], 
+    comboItems: [
+	    ['ACCEPT', 'ACCEPT'],
 	    ['REJECT', 'REJECT'],
 	    [ 'DROP', 'DROP']
-	];
-
-	me.callParent();
-    }
+	]
 });
diff --git a/www/manager6/grid/FirewallOptions.js b/www/manager6/grid/FirewallOptions.js
index f94be6c..a2f9954 100644
--- a/www/manager6/grid/FirewallOptions.js
+++ b/www/manager6/grid/FirewallOptions.js
@@ -94,7 +94,7 @@ Ext.define('PVE.FirewallOptions', {
 			xtype: 'pveKVComboBox',
 			name: name,
 			fieldLabel: name,
-			data: [['nolog', 'nolog'], ['info', 'info'], ['err', 'err'],
+			comboItems: [['nolog', 'nolog'], ['info', 'info'], ['err', 'err'],
 			       ['warning', 'warning'], ['crit', 'crit'], ['alert', 'alert'],
 			       ['emerg', 'emerg'], ['debug', 'debug']]
 		    }
@@ -226,6 +226,6 @@ Ext.define('PVE.FirewallOptions', {
 
 	me.callParent();
 
-	me.on('show', reload);
+	me.on('activate', reload);
     }
 });
-- 
2.1.4





More information about the pve-devel mailing list