[pve-devel] [PATCH container 1/3] Fix #791: warn when resize2fs fails

[Wolfgang Bumiller]

Should I resend just that patch or the whole series?
I also have another patch pending which I can send either
separately or as part of the v2 series.

> On February 5, 2016 at 10:42 AM Dietmar Maurer <dietmar at proxmox.com> wrote:
> 
> 
> > -			PVE::Tools::run_command(['unshare', '-m', '--', 'sh', '-c', $cmd]);
> > +			eval {
> > +			    PVE::Tools::run_command(['unshare', '-m', '--', 'sh', '-c', $cmd]);
> > +			};
> 
> I would also add the 'warn' statement directly after the eval here
> 
> >  		    } else {
> > -			PVE::Tools::run_command(['e2fsck', '-f', '-y', $path]);
> > -			PVE::Tools::run_command(['resize2fs', $path]);
> > +			eval {
> > +			    PVE::Tools::run_command(['e2fsck', '-f', '-y', $path]);
> > +			    PVE::Tools::run_command(['resize2fs', $path]);
> > +			};
> 
> and here
> 
> >  		    }
> 
> instead of this one
> 
> > +		    warn "Failed to update the container's filesystem: $@\n";