[pve-devel] [PATCH pve-manager v2] ext6migrate: push array elements separately

Emmanuel Kasper e.kasper at proxmox.com
Wed Feb 3 16:24:44 CET 2016


This fix is needed for buttons and columns to be properly displayed when
loading the component.
---
 www/manager6/grid/FirewallRules.js | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/www/manager6/grid/FirewallRules.js b/www/manager6/grid/FirewallRules.js
index ce19c76..ab3207b 100644
--- a/www/manager6/grid/FirewallRules.js
+++ b/www/manager6/grid/FirewallRules.js
@@ -121,7 +121,7 @@ Ext.define('PVE.FirewallRulePanel', {
 	    });
 	}
 
-	me.column1.push([
+	me.column1.push(
 	    {
 		xtype: 'displayfield',
 		fieldLabel: '',
@@ -147,7 +147,7 @@ Ext.define('PVE.FirewallRulePanel', {
 		value: '',
 		fieldLabel: gettext('Destination')
 	    }
-	]);
+	);
 
 	
 	me.column2 = [
@@ -587,7 +587,7 @@ Ext.define('PVE.FirewallRules', {
 	if (me.groupBtn) {
 	    tbar.push(me.groupBtn);
 	}
-	tbar.push([ me.removeBtn, me.editBtn ]);
+	tbar.push(me.removeBtn, me.editBtn);
 
 	var render_errors = function(name, value, metaData, record) {
 	    var errors = record.data.errors;
@@ -675,7 +675,7 @@ Ext.define('PVE.FirewallRules', {
 	    });
 	}
 
-	columns.push([
+	columns.push(
 	    {
 		header: gettext('Source'),
 		dataIndex: 'source',
@@ -724,7 +724,7 @@ Ext.define('PVE.FirewallRules', {
 		    return render_errors('comment', Ext.util.Format.htmlEncode(value), metaData, record);
 		}
 	    }
-	]);
+	);
 
 	Ext.apply(me, {
 	    store: store,
-- 
2.1.4





More information about the pve-devel mailing list