[pve-devel] [PATCH pve-manager 1/3] ext6migrate: use Array.prototype.concat() instead of push()

Dietmar Maurer dietmar at proxmox.com
Wed Feb 3 14:57:49 CET 2016


> -	me.column1.push([
> +	me.column1 = me.column1.concat([

removing the [ should do the job?

>  	    {
>  		xtype: 'displayfield',
>  		fieldLabel: '',
> @@ -587,7 +587,7 @@ Ext.define('PVE.FirewallRules', {
>  	if (me.groupBtn) {
>  	    tbar.push(me.groupBtn);
>  	}
> -	tbar.push([ me.removeBtn, me.editBtn ]);
> +	tbar = tbar.concat([ me.removeBtn, me.editBtn ]);

Does the following work?

-	tbar.push([ me.removeBtn, me.editBtn ]);
+	tbar.push(me.removeBtn, me.editBtn);


>  	var render_errors = function(name, value, metaData, record) {
>  	    var errors = record.data.errors;
> @@ -675,7 +675,7 @@ Ext.define('PVE.FirewallRules', {
>  	    });
>  	}
>  
> -	columns.push([
> +	columns = columns.concat([

see above.




More information about the pve-devel mailing list