[pve-devel] applied: [PATCH container] vzdump: use --make-rslave instead of --make-rprivate

Fabian Grünbichler f.gruenbichler at proxmox.com
Tue Dec 20 11:35:40 CET 2016


On Mon, Dec 12, 2016 at 10:11:55AM +0100, Wolfgang Bumiller wrote:
> In a stop mode backup of a running container the container
> is started from this namespace, so making it private can
> cause mount point leaks.
> ---
>  src/PVE/VZDump/LXC.pm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/PVE/VZDump/LXC.pm b/src/PVE/VZDump/LXC.pm
> index 46b5bd2..0d871a1 100644
> --- a/src/PVE/VZDump/LXC.pm
> +++ b/src/PVE/VZDump/LXC.pm
> @@ -176,7 +176,7 @@ sub prepare {
>  	# If we perform mount operations, let's unshare the mount namespace
>  	# to not influence the running host.
>  	PVE::Tools::unshare(PVE::Tools::CLONE_NEWNS);
> -	PVE::Tools::run_command(['mount', '--make-rprivate', '/']);
> +	PVE::Tools::run_command(['mount', '--make-rslave', '/']);
>      }
>  }
>  
> -- 
> 2.1.4
> 
> 
> _______________________________________________
> pve-devel mailing list
> pve-devel at pve.proxmox.com
> http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel




More information about the pve-devel mailing list