[pve-devel] [PATCH manager 2/2] Rename filterFn to vmtypeFilter

Emmanuel Kasper e.kasper at proxmox.com
Thu Dec 15 16:25:59 CET 2016


since we have now two filters defined it makes sense to use
a separate name here
---
 www/manager6/grid/BackupView.js | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/www/manager6/grid/BackupView.js b/www/manager6/grid/BackupView.js
index 1de5323..a924c0a 100644
--- a/www/manager6/grid/BackupView.js
+++ b/www/manager6/grid/BackupView.js
@@ -26,17 +26,17 @@ Ext.define('PVE.grid.BackupView', {
 	    throw "no VM type specified";
 	}
 
-	var filterFn;
+	var vmtypeFilter;
 	if (vmtype === 'openvz') {
-	    filterFn = function(item) {
+	    vmtypeFilter = function(item) {
 		return item.data.volid.match(':backup/vzdump-openvz-');
 	    };
 	} else if (vmtype === 'lxc') {
-	    filterFn = function(item) {
+	    vmtypeFilter = function(item) {
 		return item.data.volid.match(':backup/vzdump-lxc-');
 	    };
 	} else if (vmtype === 'qemu') {
-	    filterFn = function(item) {
+	    vmtypeFilter = function(item) {
 		return item.data.volid.match(':backup/vzdump-qemu-');
 	    };
 	} else {
@@ -59,7 +59,7 @@ Ext.define('PVE.grid.BackupView', {
 		order: 'DESC' 
 	    },
 	    filters: [
-	        filterFn,
+	        vmtypeFilter,
 		searchFilter
 		]
 	});
@@ -107,7 +107,7 @@ Ext.define('PVE.grid.BackupView', {
 		    me.store.clearFilter(true);
 		    searchFilter.value = field.getValue();
 		    me.store.filter([
-			filterFn,
+			vmtypeFilter,
 			searchFilter
 		    ]);
 		}
-- 
2.1.4





More information about the pve-devel mailing list