[pve-devel] [PATCH container 0/4] Rebased lxc clone/move disk patches

[Dominik Csapak]

On 12/02/2016 03:44 PM, Wolfgang Bumiller wrote:
> Rebased and cleaned up W.Link's clone/move disk patches which have been
> sitting around for way too long now.
>
> Differences are:
> * removed code which used the raw Storage::vdisk_alloc and called mkfs on
>   non-subvols in favor of factoring out the allocate+mkfs code from
>   create_disks() into a separate function.
> * improved handling of error cases in copy_volume() and dropped parameter for
>   old vmid since we don't need that anymore
> * using a "move-disk" config-lock during the move disk operation instead of
>   holding the file lock - we should do this for clone-disk and in qemu as
>   well probably?
> * reordered move_volume CLI arguments to be consistent with qemu
> * improved some error messages
> * dropped the patch to implicitly create a snapshot in clone-vm since we don't
>   do this automatically with qemu either
> * not removing the experimental flag yet, waiting for reviews first, and this
>   should be done together with removing it from the 'template' call
>
> Wolfgang Bumiller (4):
>   factor out disk allocation+formatting for reuse
>   implement copy_volume
>   use copy_volume for full clones
>   add move_volume api call
>
>  src/PVE/API2/LXC.pm | 174 ++++++++++++++++++++++++++++++++++++++++++++++++----
>  src/PVE/CLI/pct.pm  |   1 +
>  src/PVE/LXC.pm      | 151 +++++++++++++++++++++++++++++++++++----------
>  3 files changed, 284 insertions(+), 42 deletions(-)
>

moving the volume from ceph to the same ceph storage fails:

command 'mount /dev/rbd/librbdpool/vm-200-disk-1 
/tmp/ct200.copy-volume/src//' failed: exit code 32
/dev/rbd1
mke2fs 1.42.12 (29-Aug-2014)
Discarding device blocks:    4096/2097152 
done
Creating filesystem with 2097152 4k blocks and 524288 inodes
Filesystem UUID: bb737e5d-48bb-4471-87a9-f509bf2a50b2
Superblock backups stored on blocks:
	32768, 98304, 163840, 229376, 294912, 819200, 884736, 1605632

Allocating group tables:  0/64     done 

Writing inode tables:  0/64     done
Creating journal (32768 blocks): done
Multiple mount protection is enabled with update interval 5 seconds.
Writing superblocks and filesystem accounting information:  0/64 
  done

mount: special device /dev/rbd/librbdpool/vm-200-disk-1 does not exist
Removing all snapshots: 100% complete...done.
Removing image: 1% complete...
Removing image: 2% complete...
Removing image: 3% complete...
Removing image: 4% complete...
Removing image: 5% complete...
Removing image: 6% complete...
Removing image: 7% complete...
Removing image: 8% complete...
Removing image: 9% complete...
Removing image: 10% complete...
Removing image: 11% complete...
Removing image: 12% complete...
Removing image: 13% complete...
Removing image: 14% complete...
Removing image: 15% complete...
Removing image: 16% complete...
Removing image: 17% complete...
Removing image: 18% complete...
Removing image: 19% complete...
Removing image: 20% complete...
Removing image: 21% complete...
Removing image: 22% complete...
Removing image: 23% complete...
Removing image: 24% complete...
Removing image: 25% complete...
Removing image: 26% complete...
Removing image: 27% complete...
Removing image: 28% complete...
Removing image: 29% complete...
Removing image: 30% complete...
Removing image: 31% complete...
Removing image: 32% complete...
Removing image: 33% complete...
Removing image: 34% complete...
Removing image: 35% complete...
Removing image: 36% complete...
Removing image: 37% complete...
Removing image: 38% complete...
Removing image: 39% complete...
Removing image: 40% complete...
Removing image: 41% complete...
Removing image: 42% complete...
Removing image: 43% complete...
Removing image: 44% complete...
Removing image: 45% complete...
Removing image: 46% complete...
Removing image: 47% complete...
Removing image: 48% complete...
Removing image: 49% complete...
Removing image: 50% complete...
Removing image: 51% complete...
Removing image: 52% complete...
Removing image: 53% complete...
Removing image: 54% complete...
Removing image: 55% complete...
Removing image: 56% complete...
Removing image: 57% complete...
Removing image: 58% complete...
Removing image: 59% complete...
Removing image: 60% complete...
Removing image: 61% complete...
Removing image: 62% complete...
Removing image: 63% complete...
Removing image: 64% complete...
Removing image: 65% complete...
Removing image: 66% complete...
Removing image: 67% complete...
Removing image: 68% complete...
Removing image: 69% complete...
Removing image: 70% complete...
Removing image: 71% complete...
Removing image: 72% complete...
Removing image: 73% complete...
Removing image: 74% complete...
Removing image: 75% complete...
Removing image: 76% complete...
Removing image: 77% complete...
Removing image: 78% complete...
Removing image: 79% complete...
Removing image: 80% complete...
Removing image: 81% complete...
Removing image: 82% complete...
Removing image: 83% complete...
Removing image: 84% complete...
Removing image: 85% complete...
Removing image: 86% complete...
Removing image: 87% complete...
Removing image: 88% complete...
Removing image: 89% complete...
Removing image: 90% complete...
Removing image: 91% complete...
Removing image: 92% complete...
Removing image: 93% complete...
Removing image: 94% complete...
Removing image: 95% complete...
Removing image: 96% complete...
Removing image: 97% complete...
Removing image: 98% complete...
Removing image: 99% complete...
Removing image: 100% complete...done.