[pve-devel] [RFC cluster] datacenter.cfg: do not use 'default_key' in migration format

Thomas Lamprecht t.lamprecht at proxmox.com
Thu Dec 1 15:56:30 CET 2016


'default_key' does not really make sense here, as the migration
format properties can be set independent of each other and can be
both optional.

Signed-off-by: Thomas Lamprecht <t.lamprecht at proxmox.com>
---

This breaks backwards compatibility in setups which used the
default_key format already.

I could add some code which handles the break we could also just wait
for 5.X where some breakages are expected and can be handled at once.


 data/PVE/Cluster.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/data/PVE/Cluster.pm b/data/PVE/Cluster.pm
index 09ed5d7..0edcc0a 100644
--- a/data/PVE/Cluster.pm
+++ b/data/PVE/Cluster.pm
@@ -1323,7 +1323,7 @@ sub ssh_merge_known_hosts {
 
 my $migration_format = {
     type => {
-	default_key => 1,
+	optional => 1,
 	type => 'string',
 	enum => ['secure', 'insecure'],
 	description => "Migration traffic is encrypted using an SSH tunnel by " .
-- 
2.1.4





More information about the pve-devel mailing list