[pve-devel] [PATCH ha-manager 1/2] LRM: do not count erroneous service as active

Dietmar Maurer dietmar at proxmox.com
Fri Apr 29 16:49:04 CEST 2016


> diff --git a/src/PVE/HA/LRM.pm b/src/PVE/HA/LRM.pm
> index fcbc33f..b7a3201 100644
> --- a/src/PVE/HA/LRM.pm
> +++ b/src/PVE/HA/LRM.pm
> @@ -180,6 +180,8 @@ sub active_service_count {
>  	next if !defined($req_state);
>  	next if $req_state eq 'stopped';
>  	next if $req_state eq 'freeze';
> +	# we mustn't touch erroneous services, so they are not active
> +	next if $req_state eq 'error';
>  
>  	$count++;
>      }

I think it is not as easy, because we use active_service_count() from
several places, and we want to count errors sometimes ....
I am not 100% sure.



More information about the pve-devel mailing list