[pve-devel] [PATCH manager 00/10] jslint fixes

Dominik Csapak d.csapak at proxmox.com
Fri Apr 29 12:06:25 CEST 2016


this series fixes the various jslint errors we get

most are harmless but fixable, some contain important
errors and have to be fixed, some are just silly and
have to be ignored

i want to highlight one special patch:
the remove trainling commas patch (3/10)

i did not really want to do this, especially since
we only support browsers which support ECMA5 or higher
(where this is not a problem), but you
cannot disable this error in jslint

one possibility would be to move to jshint
(which supports ECMA5 and 6)

also, sorry for touching this many files and single lines

note: there should be no changes in logic anywhere, only
jslint fixes, i tested it for a while and found no problems

Dominik Csapak (10):
  jslint: fix curly braces for if
  jslint: fix type confusion and property access
  jslint: remove trailing commas
  jslint: add global entries where necessary
  jslint: fix missing or extra semicolon
  jslint: fix _ prefix and 'for in' over an object
  jslint: change (x)?x:y to x || y
  jslint: fix access to uninitialized variable
  jslint: fix tab/space mixed intendation
  jslint: fix not reachable return and duplicate property

 www/manager6/Parser.js                      | 36 +++++++++++++++++------------
 www/manager6/Toolkit.js                     | 16 +++++++++----
 www/manager6/Utils.js                       |  8 +++----
 www/manager6/Workspace.js                   |  3 +++
 www/manager6/button/Split.js                |  3 +++
 www/manager6/ceph/Config.js                 |  2 +-
 www/manager6/ceph/Disks.js                  |  4 ++--
 www/manager6/ceph/OSD.js                    |  2 +-
 www/manager6/ceph/Pool.js                   |  5 +++-
 www/manager6/data/PVEProxy.js               |  2 +-
 www/manager6/data/RRDStore.js               |  4 ++--
 www/manager6/data/ResourceStore.js          |  4 ++--
 www/manager6/data/TimezoneStore.js          |  4 ++--
 www/manager6/data/reader/JsonObject.js      |  4 ++--
 www/manager6/dc/ACLView.js                  |  2 +-
 www/manager6/dc/AuthEdit.js                 | 11 +++++++--
 www/manager6/dc/Backup.js                   |  6 ++---
 www/manager6/dc/OptionView.js               |  2 +-
 www/manager6/dc/StorageView.js              |  2 +-
 www/manager6/form/BondModeSelector.js       |  2 +-
 www/manager6/form/CacheTypeSelector.js      |  2 +-
 www/manager6/form/ComboGrid.js              |  4 ++--
 www/manager6/form/DayOfWeekSelector.js      |  2 +-
 www/manager6/form/GroupSelector.js          |  2 +-
 www/manager6/form/HotplugFeatureSelector.js | 10 ++++----
 www/manager6/form/KVComboBox.js             |  2 +-
 www/manager6/form/MemoryField.js            |  4 ++--
 www/manager6/form/NodeSelector.js           |  2 +-
 www/manager6/form/RRDTypeSelector.js        |  2 +-
 www/manager6/form/RealmComboBox.js          |  2 +-
 www/manager6/form/StorageSelector.js        |  2 +-
 www/manager6/form/ViewSelector.js           |  2 +-
 www/manager6/grid/FirewallRules.js          |  8 +++----
 www/manager6/grid/PoolMembers.js            |  7 ++++--
 www/manager6/grid/ResourceGrid.js           |  2 +-
 www/manager6/ha/Config.js                   |  2 +-
 www/manager6/ha/GroupEdit.js                |  2 +-
 www/manager6/ha/ResourceEdit.js             |  4 +++-
 www/manager6/ha/Resources.js                |  6 +++--
 www/manager6/ha/StatusView.js               |  2 +-
 www/manager6/lxc/CmdMenu.js                 |  6 ++---
 www/manager6/lxc/Config.js                  |  4 ++--
 www/manager6/lxc/DNS.js                     |  2 +-
 www/manager6/lxc/Network.js                 | 34 ++++++++++++++++-----------
 www/manager6/lxc/SnapshotTree.js            |  1 -
 www/manager6/lxc/Summary.js                 |  4 ++--
 www/manager6/node/Config.js                 |  5 ++--
 www/manager6/node/NetworkEdit.js            |  2 +-
 www/manager6/node/NetworkView.js            |  2 +-
 www/manager6/node/Subscription.js           | 15 ++++++------
 www/manager6/node/Summary.js                |  8 +++----
 www/manager6/node/Tasks.js                  |  2 +-
 www/manager6/panel/ConfigPanel.js           | 12 +++++-----
 www/manager6/panel/Firewall.js              |  2 +-
 www/manager6/panel/LogView.js               |  2 +-
 www/manager6/panel/RRDChart.js              | 12 +++++-----
 www/manager6/qemu/BootOrderEdit.js          | 16 ++++++-------
 www/manager6/qemu/CPUOptions.js             | 10 ++++----
 www/manager6/qemu/Config.js                 |  4 ++--
 www/manager6/qemu/MemoryEdit.js             | 10 ++++----
 www/manager6/qemu/ProcessorEdit.js          | 20 ++++++++--------
 www/manager6/qemu/Smbios1Edit.js            | 14 +++++------
 www/manager6/qemu/Summary.js                |  6 ++---
 www/manager6/storage/ContentView.js         |  8 +++----
 www/manager6/storage/GlusterFsEdit.js       |  4 ++--
 www/manager6/storage/IScsiEdit.js           |  2 +-
 www/manager6/storage/LVMEdit.js             |  8 +++++--
 www/manager6/storage/LvmThinEdit.js         |  8 +++++--
 www/manager6/storage/NFSEdit.js             |  2 +-
 www/manager6/storage/RBDEdit.js             |  4 ++++
 www/manager6/storage/StatusView.js          |  2 +-
 www/manager6/storage/Summary.js             |  6 ++---
 www/manager6/storage/ZFSPoolEdit.js         | 12 ++++++----
 www/manager6/tree/ResourceTree.js           |  6 ++---
 www/manager6/window/Edit.js                 |  2 +-
 www/manager6/window/MigrateAll.js           |  2 +-
 www/manager6/window/SafeDestroy.js          |  6 ++---
 77 files changed, 258 insertions(+), 198 deletions(-)

-- 
2.1.4




More information about the pve-devel mailing list