[pve-devel] [PATCH manager 2/2] fix combogrid multiselect bug

Dominik Csapak d.csapak at proxmox.com
Tue Apr 26 14:00:15 CEST 2016


I sent the patch as v2.

what changed is this:

on a setValue call in the combobox, the framework now sets the rawValue 
if the displayfield is the same as the valuefield
and the store is not yet loaded (in 4 it simply set the value and hidden 
value, and returns),
but it sets the rawValue as a string (if it is an array it is joined 
with ',')

now on a subsequent getValue call, it tries to match the displayvalue 
with the rawvalue,
but in our case the displayvalue is always empty (why i could not easily 
determine, probably because the
displayfield and valuefield are the same? but i am not sure)
and the rawvalue is now the joined array

this means for extjs that the values are out of sync and
simply sets the value to rawvalue, which is the incorrect string instead 
of the array


On 04/26/2016 01:08 PM, Dietmar Maurer wrote:
>> Yes, it really is not a nice fix, but it was a fix with minimal impact
>> on other parts of our logic.
> The real question is why this worked without problems using ExtJS4?
> What changed exactly?




More information about the pve-devel mailing list