[pve-devel] [PATCH pve-manager 2/2] Do not disable a invalid previous tab, as this make the tab fields valid

Emmanuel Kasper e.kasper at proxmox.com
Mon Apr 11 14:35:59 CEST 2016


disable_at() iterates over all the fields of the previously selected
tab and disables them
however disabling an input field makes it valid for validation purposes. I can't see a reason why disabling the tab fields
is needed, since the tab already hidden
and after testing, it seems safe to remove this call

this fix a problem when going back and forth in the wizard would
make some fields uneditable for the wrong reason
---
 www/manager6/window/Wizard.js | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/www/manager6/window/Wizard.js b/www/manager6/window/Wizard.js
index 82dd04f..d2d5aae 100644
--- a/www/manager6/window/Wizard.js
+++ b/www/manager6/window/Wizard.js
@@ -156,10 +156,6 @@ Ext.define('PVE.window.Wizard', {
 	    me.down('#submit').setDisabled(!valid);    
 	    me.down('#back').setDisabled(tp.items.indexOf(newcard) == 0);
 
-	    if (oldcard && !check_card(oldcard)) {
-		disable_at(oldcard);
-	    }
-
 	    var next = tp.items.indexOf(newcard) + 1;
 	    var ntab = tp.items.getAt(next);
 	    if (valid && ntab && !newcard.onSubmit) {
-- 
2.1.4




More information about the pve-devel mailing list