[pve-devel] [PATCH common] Fix uninitialized subroutine error

Fabian Grünbichler f.gruenbichler at proxmox.com
Tue Apr 5 12:59:33 CEST 2016


---
Note: this broke all usage strings for CLI tools without a
string->filepath mapping. Sorry for letting this slip through!

 src/PVE/RESTHandler.pm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/PVE/RESTHandler.pm b/src/PVE/RESTHandler.pm
index ad76b01..8d6f577 100644
--- a/src/PVE/RESTHandler.pm
+++ b/src/PVE/RESTHandler.pm
@@ -574,8 +574,9 @@ sub usage_str {
 	    $base = "${name}[n]";
 	}
 
+	my $mapping = defined($stringfilemap) ? &$stringfilemap($name) : undef;
 	$opts .= &$get_property_description($base, 'arg', $prop->{$k}, 'text',
-					    $hidepw, &$stringfilemap($name));
+					    $hidepw, $mapping);
 
 	if (!$prop->{$k}->{optional}) {
 	    $args .= " " if $args;
-- 
2.1.4




More information about the pve-devel mailing list