[pve-devel] [PATCH pve-cluster] Remove decode from log_msg

Wolfgang Bumiller w.bumiller at proxmox.com
Thu Oct 29 11:07:42 CET 2015


> On October 29, 2015 at 11:00 AM Thomas Lamprecht <t.lamprecht at proxmox.com>
> wrote:
>
> It isn't the cleanest fix, but decode here does not really makes sense to me,
> as it's really fragile and dies at every charachter greater than 255 and the
> string is already decoded. I don't know how good syslog handles unicode, it
> would be nice if we could log in unicode.
> But encoding is a bit tricky...

IMO it should expect null-terminated bytestrings like every other sane
ASCII/UTF-8 supporting program, otherwise that's a bug..
(All other encodings are bugs anyhow in my world ;-) )
 
> Il 29 ottobre 2015 10:42:18 CET, Dietmar Maurer <dietmar at proxmox.com> ha
> scritto:
> >
> >
> >> On October 29, 2015 at 10:30 AM Dietmar Maurer <dietmar at proxmox.com>
> >wrote:
> >> 
> >> 
> >> I do not think this fixes bug 790 - not sure what this patch solve?
> >
> >
> >OK, I see how it works now. But I am not sure this is the correct fix.
> >I 
> >will do more test...
> _______________________________________________
> pve-devel mailing list
> pve-devel at pve.proxmox.com
> http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel



More information about the pve-devel mailing list