[pve-devel] [PATCH 2/4] Use new exitcodes instead of integers

[t.lamprecht at proxmox.com]

On October 29, 2015 7:57:35 AM GMT+01:00, Dietmar Maurer <dietmar at proxmox.com> wrote:
>
>> @@ -554,7 +555,7 @@ sub next_state_started {
>>  
>>  	    my $try_next = 0;
>>  	    if ($lrm_res) {
>> -		if ($lrm_res->{exit_code} == 1) {
>> +		if ($lrm_res->{exit_code} == ERROR) {
>
>It is a bit unclear what happen if we get other error codes here?

We can not act on the other error codes (at the moment) and so the behaviour stays the same as when we died (which returned the 255 error code).
But yes, it is unclear... I could log it here in a else branch so that it's clearer

>
>>  
>>  		    my $try = $master_status->{relocate_trial}->{$sid} || 0;
>>  
>> @@ -575,7 +576,7 @@ sub next_state_started {
>>  			return;
>>  
>>  		    }
>> -		} elsif ($lrm_res->{exit_code} == 0) {
>> +		} elsif ($lrm_res->{exit_code} == SUCCESS) {
>>  		    $master_status->{relocate_trial}->{$sid} = 0;
>>  		}
>>  	    }
>> -- 

-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.