[pve-devel] [PATCH 0/4] adding exit codes (replacing die's) and some refactoring

Thomas Lamprecht t.lamprecht at proxmox.com
Fri Oct 23 14:04:22 CEST 2015


This series should maintain known behaviour and only refactor some of the code base.

The main point is to eliminate the die's from the exec resource agent and return clean exit codes.
This would allow to fix some errors as the CRM now knows what failed, but this isn't implemented (if not done right it will make stuff only worse, so it's better for now to let it be as it is).

Thomas Lamprecht (4):
  Adding constants to gain more readability
  Use new exitcodes instead of integers
  exec_resource_agent: return valid exit code instead of die's
  refactor and reuse code in vm_is_ha_managed

 src/PVE/HA/Config.pm   | 13 ++++---------
 src/PVE/HA/Env/PVE2.pm | 43 +++++++++++++++++++++++++------------------
 src/PVE/HA/LRM.pm      | 11 ++++++-----
 src/PVE/HA/Manager.pm  |  9 +++++----
 src/PVE/HA/Tools.pm    | 18 ++++++++++++++++++
 5 files changed, 58 insertions(+), 36 deletions(-)

-- 
2.1.4




More information about the pve-devel mailing list