[pve-devel] [PATCH 5/5] DRBD: Implement snapshots.

[Philipp Marek]

> First, code looks reasonable to me, but I am unable to test
> without a working rollback. Some comments inline:
> > -    die "Snapshot not implemented on DRBD\n" if $snapname;
> > +    return activate_volume_from_snapshot(@_) if $snapname;
> 
> I would prefer to list all parameters by name (instead of using @_)
> > -    die "Snapshot not implemented on DRBD\n" if $snapname;
> > +    return deactivate_volume_from_snapshot(@_) if $snapname;
> 
> same here
I changed both.

> > +        snapshot => { current => 1, snap => 1}, ## what's the difference?
> 
> just use
> 
> +  snapshot => { current => 1 },
done, thanks a lot!