[pve-devel] [PATCH pve-manager] Force setting the Macro combobox to an empty string when the user erases the content

Dietmar Maurer dietmar at proxmox.com
Thu Oct 15 13:37:31 CEST 2015


Would this also fix the bug - please can you test?

diff --git a/www/manager/grid/FirewallRules.js
b/www/manager/grid/FirewallRules.js
index 17f5411..1f65cb5 100644
--- a/www/manager/grid/FirewallRules.js
+++ b/www/manager/grid/FirewallRules.js
@@ -59,7 +59,7 @@ Ext.define('PVE.FirewallRulePanel', {
        // hack: editable ComboGrid returns nothing when empty, so we need to
set ''
        // Also, disabled text fields return nothing, so we need to set ''
 
-       Ext.Array.each(['source', 'dest', 'proto', 'sport', 'dport'],
function(key) {
+       Ext.Array.each(['source', 'dest', 'proto', 'sport', 'dport', 'macro'],
function(key) {
            if (values[key] === undefined) {
                values[key] = '';
            }



More information about the pve-devel mailing list