[pve-devel] [PATCH v4 pve-container] Add new pct fsck command, to check the rootfs of a container for consistency

Emmanuel Kasper e.kasper at proxmox.com
Mon Oct 12 14:41:20 CEST 2015


 > I don't think parsing and bind-mount check need to be part of the 'if'
> clause. Checking in case of the rootfs, too, doesn't harm, and you might
> want to be able to put a rootfs on a block device, too. (Though this
> currently doesn't seem to be possible).
> 
> Also, while you do want to skip bind-mounts, you don't want to skip
> block devices, so this should be m|^/(?!dev/)| (or add
> && ... !~ m|^/dev/|) ;-)

I didn't know containers supported direct access to block devices
without using the storage framework, thanks for pointing that.






More information about the pve-devel mailing list