[pve-devel] [RFC pve-ha-manager 1/5] add FenceConfig class for external fencing devices

[Thomas Lamprecht]

Am 15.11.2015 um 10:33 schrieb Dietmar Maurer:
>
>> On November 11, 2015 at 12:39 PM Thomas Lamprecht <t.lamprecht at proxmox.com>
>> wrote:
>>
>>
>> Add a FenceConfig package which includes methods to parse a config
>> file for fence devices in the format specified by dlm.conf, see the
>> Fencing section in the dlm.conf manpage for more details to the
>> format.
>>
>> With this we can extract commands for fencing a node from the parsed
>> file.
>>
> Fencing is a critical part, so it would be great to have regression test
> for the FenceConfig class. Simply check get_commands() results for
> predefined configuration files... 

Yes I completely agree, this should be done, I will include regressions
tests in the next version of this patch series.

>
>> For now we assume that the fence config resides under
>> /etc/pve/ha/fence_devices.cfg
> For me 'fence.cfg' would be good enough.

Sounds good to me too.