[pve-devel] [PATCH pve-manager] make startall wait up to 60 seconds for quorum

[Thomas Lamprecht]

On 11/09/2015 12:04 PM, Alexandre DERUMIER wrote:
> Hi,
>
> I think we could setup it to 125s, because this is the rfc standard for igmp querier interval
>
> (and this is the default too on cisco switch for example)
Yes would be good for me, but there's to note that timeout isn't 
directly related only to those.
The max possible timeout would be even a bit more, as pve-manager starts 
earlier.

I'll signoff every seconds value greater than 60s edited into this patch.
>
> ----- Mail original -----
> De: "Thomas Lamprecht" <t.lamprecht at proxmox.com>
> À: "pve-devel" <pve-devel at pve.proxmox.com>
> Envoyé: Lundi 9 Novembre 2015 11:44:25
> Objet: [pve-devel] [PATCH pve-manager] make startall wait up to 60 seconds	for quorum
>
> Previously we waited 10 seconds, in PVE 4 system sometimes need more
> time to initialize all services so the didn't execute the startall
> command even if a few seconds later cfs quorum was etablished.
> This is a background process started from the pve-manager init
> script, thus waiting doesn't interferes with other processes, so
> wait long enough.
>
> Signed-off-by: Thomas Lamprecht <t.lamprecht at proxmox.com>
> ---
> PVE/API2/Nodes.pm | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/PVE/API2/Nodes.pm b/PVE/API2/Nodes.pm
> index 9b7bb9f..0581e1d 100644
> --- a/PVE/API2/Nodes.pm
> +++ b/PVE/API2/Nodes.pm
> @@ -1234,8 +1234,8 @@ __PACKAGE__->register_method ({
>
> $rpcenv->{type} = 'priv'; # to start tasks in background
>
> - # wait up to 10 seconds for quorum
> - for (my $i = 10; $i >= 0; $i--) {
> + # wait up to 60 seconds for quorum
> + for (my $i = 60; $i >= 0; $i--) {
> last if PVE::Cluster::check_cfs_quorum($i != 0 ? 1 : 0);
> sleep(1);
> }