[pve-devel] qemu 4.4 : rbd : snapshot memory, savevm is hanging

[Alexandre DERUMIER]

I think this should work:

QDict *options = NULL; 
options = qdict_new(); 
qdict_put(options, "driver", qstring_from_str('raw')); 
ret = bdrv_open(&snap_state.bs, statefile, NULL, options, bdrv_oflags, drv, ...)




About rbd, something strange, 

when I try a first state snapshot it's always working,
but try to launch a second always hang (on vm_stop).

inside vm_stop, they are some
bdrv_drain_all();
ret = bdrv_flush_all();


I just wonder if it couldn't be an old bs pointer not correctly closed.



----- Mail original -----
De: "aderumier" <aderumier at odiso.com>
À: "dietmar" <dietmar at proxmox.com>
Cc: "pve-devel" <pve-devel at pve.proxmox.com>
Envoyé: Dimanche 8 Novembre 2015 14:52:40
Objet: Re: [pve-devel] qemu 4.4 : rbd : snapshot memory, savevm is hanging

>>I thought we always use 'raw' format for statefile? 

Oh, yes, you are right. 


----- Mail original ----- 
De: "dietmar" <dietmar at proxmox.com> 
À: "aderumier" <aderumier at odiso.com>, "pve-devel" <pve-devel at pve.proxmox.com> 
Envoyé: Dimanche 8 Novembre 2015 14:18:57 
Objet: Re: [pve-devel] qemu 4.4 : rbd : snapshot memory, savevm is hanging 

> On November 8, 2015 at 1:03 PM Alexandre DERUMIER <aderumier at odiso.com> wrote: 
> 
> 
> >> it's since qemu 2.3, we need to specify format=raw, we are already doing it 
> >> 
> >> for -drive , I'm not sure with vmstate open. 
> >> 
> 
> >>>Oh, I though the PVE::Storage already fixed that ... 
> >Currently we use PVE::QemuServer::qemu_img_format, to generate the format=raw 
> >string in 
> >differente place (-drive , mirror,...) 
> 
> I think we should pass format in a new qmp option, 
> and do like qemu-img 
> 
> 
> QDict *options = NULL; 
> 
> if (fmt) { 
> options = qdict_new(); 
> qdict_put(options, "driver", qstring_from_str(fmt)); 
> } 
> 
> ret = bdrv_open(&snap_state.bs, statefile, NULL, options, bdrv_oflags, drv, 
> &local_err); 

I thought we always use 'raw' format for statefile?