[pve-devel] qemu 4.4 : rbd : snapshot memory, savevm is hanging

[Dietmar Maurer]

> On November 8, 2015 at 1:03 PM Alexandre DERUMIER <aderumier at odiso.com> wrote:
> 
> 
> >> it's since qemu 2.3, we need to specify format=raw, we are already doing it
> >> 
> >> for -drive , I'm not sure with vmstate open. 
> >> 
> 
> >>>Oh, I though the PVE::Storage already fixed that ... 
> >Currently we use PVE::QemuServer::qemu_img_format, to generate the format=raw
> >string in 
> >differente place (-drive , mirror,...)
> 
> I think we should pass format in a new qmp option,
> and do like qemu-img
> 
> 
>    QDict *options = NULL;
>  
>    if (fmt) {
>         options = qdict_new();
>         qdict_put(options, "driver", qstring_from_str(fmt));
>    }
> 
>    ret = bdrv_open(&snap_state.bs, statefile, NULL, options, bdrv_oflags, drv,
> &local_err);

I thought we always use 'raw' format for statefile?