[pve-devel] [PATCH 2/2] moving more binary initialization code into prepare()

Dietmar Maurer dietmar at proxmox.com
Fri May 29 13:59:48 CEST 2015


> diff --git a/bin/pveceph b/bin/pveceph
> index 18a4e8b..092c569 100755
> --- a/bin/pveceph
> +++ b/bin/pveceph
> @@ -24,19 +24,34 @@ use PVE::CLIHandler;
>  
>  use base qw(PVE::CLIHandler);
>  
> -$ENV{'PATH'} = '/sbin:/bin:/usr/sbin:/usr/bin';

Sorry, but why do you want to move this inside prepare?

> +my $cmddef;
> +my $nodename;
>  
> -initlog ('pveceph');

same here

And what exactly is the problem with nodename? Seems we can
call PVE::INotify::nodename() before inotify_init without problems?
So why all this restructuring?



More information about the pve-devel mailing list