[pve-devel] [PATCH 0/2] Start making use of daemon initialization changes

Wolfgang Bumiller w.bumiller at proxmox.com
Fri May 29 13:44:48 CEST 2015


I've split this patch up into two parts because the second part needs some
reviewing. The issue I encountered in these two files is that the
$nodename is not only initialized early but also used in $cmddef. I'm
now updating the $cmddef in prepare().
The functions where it matters (like RESTHandler::cli_handler) will
only ever see the updated $cmddef, while the only other function which
deals with $cmddef is RESTHandler::usage_str, which gets an undefined
ndoename. However, according to the comment above this function this
info will not actually be used.
It only ever checks the existence of it in the form:

	next if defined($fixed_param->{$k});

Wolfgang Bumiller (2):
  move trivial preparations into prepare()
  moving more binary initialization code into prepare()

 bin/pveceph         | 37 +++++++++++++++++++++++++------------
 bin/pvedaemon       | 10 ++++++----
 bin/pveproxy        | 18 ++++++++++--------
 bin/pvestatd        | 18 +++++++++++-------
 bin/pvesubscription | 31 ++++++++++++++++++++-----------
 bin/spiceproxy      | 18 ++++++++++--------
 6 files changed, 82 insertions(+), 50 deletions(-)

-- 
2.1.4




More information about the pve-devel mailing list