[pve-devel] [PATCH] Add copy_disk and change_disk command
dietmar at proxmox.com
Fri May 22 18:30:15 CEST 2015
> Splitting move_disk : what i have done is a copy/paste of move_disk and
> then remove uneeded lines. If we cut move_disk (move_disk will then
> launch copy_disk and change_disk) we will avoid to do a copy/paste wich
> is allways a bad way of coding.
> So i will try to rewrite move_disk to allow splitting it in 2 parts, one
> will copy disk and the second one will change Proxmox config.
> move_disk we become a call to those 2 new functions.
> What are you thinking about that ?
First, I am not really convinced - You want only use that make VM backups?
I am asking because this does not have snapshot semantics if you have more
that one disk. Also, on a reasonable storage, you can simply make a snapshot,
which is much faster as easier to manage.
There are so many options when people talk about backups, so I want to
make sure I understand your needs.
Second, I guess you could add an option to move_disk which avoids
changing the config. Changing the config can be done with other
API calls (remove/add disk).
More information about the pve-devel