[pve-devel] move iothread option from global to disk

[Alexandre DERUMIER]

>>I would like also to keep iothread option to drive, to enable or not iothread, 
>>even if we choose scsihw: virtio-scsi-(multi|single). 
>>multiqueue option will be added also to this scsihw: virtio-scsi-(multi|single). 

we could allow iothread,multiqueue for scsihw: virtio-scsi-pci  or virtio-scsi-(multi|single),

the only difference is that virtio-scsi-(multi|single) give us a maxdev=1 , instead 256.

Like this it can be really clean.


----- Mail original -----
De: "aderumier" <aderumier at odiso.com>
À: "dietmar" <dietmar at proxmox.com>
Cc: "pve-devel" <pve-devel at pve.proxmox.com>
Envoyé: Mercredi 25 Mars 2015 08:12:54
Objet: Re: [pve-devel] move iothread option from global to disk

>>We slowly run out of free PCI slots ... 
>> 
>>So if we add this patch, we need a way to add another pci bus - any idea? 
I don't known if we can add a new bridge on top of another bridge (instead on top of root bridge). 

Another possibility, if "scsihw: virtio-scsi-multi" , we don't need 
scsihw0 => { bus => 0, addr => 5 }, 
scsihw1 => { bus => 0, addr => 6 }, 

So, we can reuse them to plug a dedicated bridge with only virtio-scsi-multi controllers 


>>And I think it is maybe better to have different scsihw types: 
>> 
>>scsihw: virtio-scsi-pci # what we have now 
>> 
>>scsihw: virtio-scsi-multi # one io-thread per drive 
>> 
>>I guess that would make hotplug code simpler? 

yes, it'll make the code a lot more clean. 
But maybe "virtio-scsi-multi" name is confusing ? because we have only 1 disk by controller. 
maybe "virtio-scsi-single" 

I would like also to keep iothread option to drive, to enable or not iothread, 
even if we choose scsihw: virtio-scsi-(multi|single). 
multiqueue option will be added also to this scsihw: virtio-scsi-(multi|single). 





----- Mail original ----- 
De: "dietmar" <dietmar at proxmox.com> 
À: "aderumier" <aderumier at odiso.com> 
Cc: "pve-devel" <pve-devel at pve.proxmox.com> 
Envoyé: Mercredi 25 Mars 2015 07:18:56 
Objet: Re: [pve-devel] move iothread option from global to disk 

> (You can plug 256 drives on 1 controller, 
> so with 1disk by controller, I only manage 14 drives (which is the limit of 
> gui currently)) 

We slowly run out of free PCI slots ... 

So if we add this patch, we need a way to add another pci bus - any idea? 

And I think it is maybe better to have different scsihw types: 

scsihw: virtio-scsi-pci # what we have now 

scsihw: virtio-scsi-multi # one io-thread per drive 

I guess that would make hotplug code simpler? 
_______________________________________________ 
pve-devel mailing list 
pve-devel at pve.proxmox.com 
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel