[pve-devel] balloon bug in qemu 2.1 ?

[Alexandre DERUMIER]

>>only max_mem is missing from orignal qmp query-balloon or qom-get. 
>>No sure we need to keep a patch just for this. We can use vmid.conf value. (with pending, now we also have true value) 

This can be retrieve too with qom : stat-total-memory


so,only "actual"  balloon value need to an extra qmp query.


----- Mail original -----
De: "aderumier" <aderumier at odiso.com>
À: "dietmar" <dietmar at proxmox.com>
Cc: "pve-devel" <pve-devel at pve.proxmox.com>
Envoyé: Vendredi 6 Mars 2015 06:53:46
Objet: Re: [pve-devel] balloon bug in qemu 2.1 ?

>> Maybe it's time to remove this patch, and use qemu qom implementation ? 
>> 
>>Would be great, but current code needs 'actual, max_mem'? 

just send a patch. 

the actual value is return by original query-balloon. 

only max_mem is missing from orignal qmp query-balloon or qom-get. 
No sure we need to keep a patch just for this. We can use vmid.conf value. (with pending, now we also have true value) 




----- Mail original ----- 
De: "dietmar" <dietmar at proxmox.com> 
À: "aderumier" <aderumier at odiso.com> 
Cc: "pve-devel" <pve-devel at pve.proxmox.com> 
Envoyé: Vendredi 6 Mars 2015 06:32:22 
Objet: Re: [pve-devel] balloon bug in qemu 2.1 ? 

> As far I remember, we have make the virtio-balloon-fix-query.patch patch, 
> because at this time, it was impossible to use qom guest-stats to retrieve all 
> values in 1 call 
> (And we wanted to avoid to call 5-6 times qom guest-stats) 

yes, we use that inside QemuServer::vmstatus, so that needs to be fast because 
we call it frequently. 


> Now,it seem that we can get all values directly. (excluding actual-max_mem). 
> 
> 
> Maybe it's time to remove this patch, and use qemu qom implementation ? 

Would be great, but current code needs 'actual, max_mem'?