[pve-devel] [PATCH_V3] Bug Fix 602

[Dietmar Maurer]

On 03/06/2015 05:57 AM, Dietmar Maurer wrote:
> So this regex will never match! 

oh, just saw that the colon is added inside run_command -  so just 
ignore this.

>> +
>> +	if ($ret =~ m/.*: dataset is busy.*/){
>> +
>> +	    for(my $i = 0; $ret && $i < 5; $i++){
>> +		sleep(1);
>> +		
>> +		eval {$ret =  $class->zfs_request($scfg, undef, 'destroy', '-r',
>> "$scfg->{pool}/$zvol");};
> Also, this is a code duplication, and can be avoided easily.
>   
>> +		$ret = $@ if $@;		
>> +	    }
>> +
>> +	    die $ret if $ret;
>> +	} else {
>> +	    die "$ret";
>> +	}
>> +    }
>>   }
>>   
>>   sub zfs_list_zvol {
>> -- 
>> 1.7.10.4
>>
>>
>> _______________________________________________
>> pve-devel mailing list
>> pve-devel at pve.proxmox.com
>> http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
>>