[pve-devel] [PATCH] qmp drive_add : remove backslashes from $drive string

Dietmar Maurer dietmar at proxmox.com
Tue Mar 3 06:24:06 CET 2015


On 03/02/2015 08:54 AM, Alexandre DERUMIER wrote
> $drive string:
>
> 'file=rbd:poolceph1/vm-101-disk-6:mon_host=10.5.0.11\;10.5.0.12\;10.5.0.13:id=admin:auth_supported=cephx:keyring=/etc/pve/priv/ceph/cephzimbra.keyring,if=none,id=drive-virtio1,aio=native,cache=none,detect-zeroes=on'
>

I am starting to wonder where those "\;" comes from. Its form 
PVE::Storage::RBDPlugin::addslashes().

Maybe we should remove that quoting there (and quote later when we 
really need it)?

  Also, it looks monhost parser is configured wrong there:

     monhost => {
         description => "Monitors daemon ips.",
         type => 'string',
     },

Instead, this should be a list of monitor ips (not string)?

     monhost => {
         description => "Monitors daemon ips.",
         type => 'string', format => 'pve-storage-monhost-list'
     },







More information about the pve-devel mailing list