[pve-devel] lxc : disk file names, should'nt we use same pattern than qemu ?

[Alexandre DERUMIER]

>>vm-$vmid-rootfs-$i.raw 
>>
>>or 
>>
>>vm-$vmid-ext4fs-$i.raw 
>>
>>or 
>>
>>vm-$vmid-lxc-$i.raw 
>>
>>? 



>>do we really need to have rootfs or ext4fs in filename ? 

for example : lxc.rootfs = .../100/vm-100-rootfs.raw


if not, why not something generic like ct-$vmid-$i.raw ?

(ct for container, vm for vms)

lxc.rootfs = .../100/ct-100-1.raw





Also,
I see that currently we put loop,nbd in config with path

lxc.rootfs = loop:/var/lib/vz/images/100/ct-100-1.raw

I think we should do like in qemu

lxc.rootfs = storeid:100/ct-100-1.raw
Then generate the path , activate_volumes with mounting loop,rbd  at ct start.


I think we can't use this syntax directly because lxc_start need full path for lxc.rootfs or lxc.mount.entry ?

Maybe can we use 
pve.volid1 = storeid:mountpoint
pve.volid2 = storeid:mountpoint
pve.volid3 = storeid:mountpoint

to store config,
the at vm_start, update lxc.rootfs && lxc.mount.entry  ?




 




----- Mail original -----
De: "dietmar" <dietmar at proxmox.com>
À: "aderumier" <aderumier at odiso.com>, "pve-devel" <pve-devel at pve.proxmox.com>
Envoyé: Jeudi 30 Juillet 2015 09:52:39
Objet: Re: [pve-devel] lxc : disk file names, should'nt we use same pattern than qemu ?

> On July 30, 2015 at 9:18 AM Alexandre DERUMIER <aderumier at odiso.com> wrote: 
> 
> 
> Currently for lxc, 
> 
> we create root disk with vm-$vmid-rootfs.raw. 
> 
> I'm thinking if we want to add multiple disk support, with different mount 
> points, 
> 
> Could be use same format than qemu 
> 
> vm-$vmid-disk-$i 
> 
> Like this, we could re-use easily PVE::Storage. 

I would like have different names for kvm and lxc images: 

vm-$vmid-rootfs-$i.raw 

or 

vm-$vmid-ext4fs-$i.raw 

or 

vm-$vmid-lxc-$i.raw 

?