[pve-devel] [PATCH] add vlan aware ifupdown script v3

[Alexandre DERUMIER]

maybe this iproute2 (4.1) patch

http://git.kernel.org/cgit/linux/kernel/git/shemminger/iproute2.git/commit/?id=c079e121a73af5eb49e003b13607e8a690331df6
"libnetlink: add size argument to rtnl_talk
There have been several instances where response from kernel
has overrun the stack buffer from the caller. Avoid future problems
by passing a size argument.

Also drop the unused peer and group arguments to rtnl_talk.
"


----- Mail original -----
De: "aderumier" <aderumier at odiso.com>
À: "Wolfgang Bumiller" <w.bumiller at proxmox.com>
Cc: "pve-devel" <pve-devel at pve.proxmox.com>
Envoyé: Mercredi 29 Juillet 2015 16:57:09
Objet: Re: [pve-devel] [PATCH] add vlan aware ifupdown script v3

from this similar redhat bugzilla 
https://bugzilla.redhat.com/show_bug.cgi?id=1086512 

this is because the buffer in libnetlink (iproute2) is too short 
http://git.kernel.org/cgit/linux/kernel/git/shemminger/iproute2.git/tree/lib/libnetlink.c 

It's like each vlan (even if in a range, and not display), fill the buffer. (I'm not sure which buf is the good one). 


I have send a bug report mail to the vlan range patch author. 



----- Mail original ----- 
De: "aderumier" <aderumier at odiso.com> 
À: "Wolfgang Bumiller" <w.bumiller at proxmox.com> 
Cc: "pve-devel" <pve-devel at pve.proxmox.com> 
Envoyé: Mercredi 29 Juillet 2015 16:19:34 
Objet: Re: [pve-devel] [PATCH] add vlan aware ifupdown script v3 

>>I could limit the number of vlans, with adding dynamicaly to ethX|bondX vlans to allow, when the vm is starting. 
>>If user want to tag inside the vm, we could add an option "vlans filter" or something like that. 

I have the "message truncated" warning when I have defined around 1800vlans. (can be 1-1800 on 1 interface, or 1-900 + 1-900 on 2 interfaces,...). 


----- Mail original ----- 
De: "aderumier" <aderumier at odiso.com> 
À: "Wolfgang Bumiller" <w.bumiller at proxmox.com> 
Cc: "pve-devel" <pve-devel at pve.proxmox.com> 
Envoyé: Mercredi 29 Juillet 2015 16:08:34 
Objet: Re: [pve-devel] [PATCH] add vlan aware ifupdown script v3 

>>>>I have seen that too :( 
>>maybe 
>>https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=fed0a159c8c5e453d79d6a73897c576efea0a8a5 
>>"bridge: fix link notification skb size calculation to include vlan ranges" 
>> 
>>? 
Still no luck with kernel 4.1. 

I could limit the number of vlans, with adding dynamicaly to ethX|bondX vlans to allow, when the vm is starting. 

If user want to tag inside the vm, we could add an option "vlans filter" or something like that. 



----- Mail original ----- 
De: "aderumier" <aderumier at odiso.com> 
À: "Wolfgang Bumiller" <w.bumiller at proxmox.com> 
Cc: "pve-devel" <pve-devel at pve.proxmox.com> 
Envoyé: Mercredi 29 Juillet 2015 14:08:59 
Objet: Re: [pve-devel] [PATCH] add vlan aware ifupdown script v3 

>>both the testbridge 
>>>>and dum0 interface disappear even from the output of `ip link` which 
>>>>also throws that error. This is highly annoying. 

>>I have seen that too :( 
maybe 
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=fed0a159c8c5e453d79d6a73897c576efea0a8a5 
"bridge: fix link notification skb size calculation to include vlan ranges" 

? 


----- Mail original ----- 
De: "aderumier" <aderumier at odiso.com> 
À: "Wolfgang Bumiller" <w.bumiller at proxmox.com> 
Cc: "pve-devel" <pve-devel at pve.proxmox.com> 
Envoyé: Mercredi 29 Juillet 2015 13:59:15 
Objet: Re: [pve-devel] [PATCH] add vlan aware ifupdown script v3 

both the testbridge 
>>and dum0 interface disappear even from the output of `ip link` which 
>>also throws that error. This is highly annoying. 

I have seen that too :( 




----- Mail original ----- 
De: "Wolfgang Bumiller" <w.bumiller at proxmox.com> 
À: "aderumier" <aderumier at odiso.com> 
Cc: "dietmar" <dietmar at proxmox.com>, "pve-devel" <pve-devel at pve.proxmox.com> 
Envoyé: Mercredi 29 Juillet 2015 13:47:20 
Objet: Re: [pve-devel] [PATCH] add vlan aware ifupdown script v3 

The manual way works for me on my host. The /etc/network/interfaces way 
doesn't. Presumably because I didn't `apt-get purge vlan`. 
In my test VMs where I purged vlan and pve-manager and reinstalled the 
patched pve-manager it all works fine. 

What I really hate about this is the whole "Message truncated" issue, as 
this doesn't only apply to the output of `bridge vlan show`, but also if 
I add vlans 2-4094 to my test dummy interface dum0, both the testbridge 
and dum0 interface disappear even from the output of `ip link` which 
also throws that error. This is highly annoying. 

On Wed, Jul 29, 2015 at 01:20:19PM +0200, Alexandre DERUMIER wrote: 
> >>no 
> 
> Damn, with an empty /etc/network/interfaces 
> 
> 
> #brctl addbr testbridge 
> #echo 1 > /sys/class/net/testbridge/bridge/vlan_filtering 
> #bridge vlan add dev testbridge vid 100 self 
> 
> #bridge -c vlan 
> 
> testbridge 1 PVID Egress Untagged 
> 100 
> 
> #brctl addif testbridge eth0 
> #bridge -c vlan 
> 
> eth0 1PVID Egress Untagged 
> 
> testbridge 1 PVID Egress Untagged 
> 100 
> 
> 
> #bridge vlan add dev eth0 vid 2-4094 
> 
> eth0 1PVID Egress Untagged 
> 2-4094 
> testbridge 1 PVID Egress Untagged 
> 100 
> 
> 
> can you reproduce it ? 
> 
> 
> ----- Mail original ----- 
> De: "dietmar" <dietmar at proxmox.com> 
> À: "aderumier" <aderumier at odiso.com> 
> Cc: "pve-devel" <pve-devel at pve.proxmox.com> 
> Envoyé: Mercredi 29 Juillet 2015 12:47:32 
> Objet: Re: [pve-devel] [PATCH] add vlan aware ifupdown script v3 
> 
> > does it work better if you setup the ip on bridge vlan interface ? 
> 
> no 
> _______________________________________________ 
> pve-devel mailing list 
> pve-devel at pve.proxmox.com 
> http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel 
_______________________________________________ 
pve-devel mailing list 
pve-devel at pve.proxmox.com 
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel 
_______________________________________________ 
pve-devel mailing list 
pve-devel at pve.proxmox.com 
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel 
_______________________________________________ 
pve-devel mailing list 
pve-devel at pve.proxmox.com 
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel 
_______________________________________________ 
pve-devel mailing list 
pve-devel at pve.proxmox.com 
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel 
_______________________________________________ 
pve-devel mailing list 
pve-devel at pve.proxmox.com 
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel