[pve-devel] javascript error since upgrade to novnc0.5-2

[Alexandre DERUMIER]

Hi Stefan, 

>>still on stable-3. 

they are new parameters in NoVncIndex.pm, in pve-manager

https://git.proxmox.com/?p=pve-manager.git;a=commit;h=960fea8c77243495536bb44b696dda8cb0056065
https://git.proxmox.com/?p=pve-manager.git;a=commit;h=c03d35f0247603cbb60ff39536f0801a03f11699


----- Mail original -----
De: "Stefan Priebe" <s.priebe at profihost.ag>
À: "pve-devel" <pve-devel at pve.proxmox.com>
Envoyé: Mercredi 29 Juillet 2015 09:28:06
Objet: [pve-devel] javascript error since upgrade to novnc0.5-2

Hi, 

still on stable-3. 

Sicne upgrading to novnc 0.5-2 i get on some hosts the following error 
in novnc. 

pveui.js:284 Uncaught TypeError: Cannot read property 'type' of null 
pveui.js:284UI.updateSetting @ pveui.js:304UI.pve_start.start_vnc_viewer 
@ pveui.js:1615UI.pve_start.UI.API2Request.success @ 
pveui.js:1627UI.API2Request.xhr.onload @ pveui.js:1199 

This is: 
// Read form control compatible setting from cookie 
getSetting: function(name) { 
var ctrl = $D('noVNC_' + name); 
var val = WebUtil.readSetting(name); 
if (typeof val !== 'undefined' && val !== null && ctrl.type 
=== 'checkbox') { 
if (val.toString().toLowerCase() in {'0':1, 'no':1, 
'false':1}) { 
val = false; 
} else { 
val = true; 
} 
} 
return val; 
}, 


Stefan 
_______________________________________________ 
pve-devel mailing list 
pve-devel at pve.proxmox.com 
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel