[pve-devel] [PATCH] add vlan aware bridge ifupdown script v2

[Alexandre DERUMIER]

>>So you don't want that we include the vlan scripts you posted? 
vlan package and script are only need, if we want to create vlan interface from brigde_ports,
without defined them. (and it's buggy currently)


if-pre-up.d/bridge is a big crap too:


"
bridge_parse_ports $INTERFACES | while read i
do
  for port in $i
  do
    # We attach and configure each port of the bridge
    if [ "$MODE" = "start" ] && [ ! -d /sys/class/net/$IFACE/brif/$port ]; then
      if [ -x /etc/network/if-pre-up.d/vlan ]; then
        env IFACE=$port /etc/network/if-pre-up.d/vlan
      fi

      ...
      brctl addif $IFACE $port && ip link set dev $port up
"

that's really suck, as we can defined any interface in bridge_ports. (they are no relation with others "auto iface...");
it don't use ifup.
That mean that vlan must be created manually through vlan script 
and also so if you try to ifdown an interface enabled with bridge script, you'll have an error "interface not enabled",
because ifup has not been used.


But ok, we can add my vlan version, at least to not break current configuration if user don't define vlan interface.
I'll send a patch today.


(BTW, ifdown2 have a branch debian-prep, 
https://github.com/CumulusNetworks/ifupdown2/commits/debian-prep.

They are currently cleaning code, remove cumulus special code, so I think they will push it to debian soon)



----- Mail original -----
De: "dietmar" <dietmar at proxmox.com>
À: "aderumier" <aderumier at odiso.com>
Cc: "Wolfgang Bumiller" <w.bumiller at proxmox.com>, "datanom.net" <mir at datanom.net>, "pve-devel" <pve-devel at pve.proxmox.com>
Envoyé: Mardi 28 Juillet 2015 21:03:48
Objet: Re: [pve-devel] [PATCH] add vlan aware bridge ifupdown script v2

> >>Besides, would you mind to send your scripts to the debian maintainers? 
> >>They looks like an improvement to me :-) 
> 
> I'm not sure, but maybe the best way is to remove the vlan package totally. 
> It seem like deprecated. (vconfig, manage only old interfaces names,...) 

So you don't want that we include the vlan scripts you posted?