[pve-devel] [PATCH] add vlan aware bridge ifupdown script v2

[Alexandre DERUMIER]

>> + if [[ $port =~ ^(eth|bond|wlan)[0-9]{1,2}$ ]] 


>>Isn't there a better way to do this?
>>Like checking the interface type via /proc? Because otherwise we end up
>>with more threads like:
>><http://forum.proxmox.com/threads/22504-Unable-to-see-Infiniband-interfaces-in-Proxmox>
>>
>>Restricting interfaces to names has always been problematic.
>>We already have a problem when someone installes pve packages from a
>>normal debian distribution after enabling systemd's interface naming
>>scheme.

yes, I think also it's really stupid to restrict to specific name.

ifupdown2 allow any name for vlan interface (*.*) for example
https://github.com/CumulusNetworks/ifupdown2/blob/master/ifupdown2/addons/vlan.py





----- Mail original -----
De: "Wolfgang Bumiller" <w.bumiller at proxmox.com>
À: "aderumier" <aderumier at odiso.com>
Cc: "pve-devel" <pve-devel at pve.proxmox.com>
Envoyé: Mardi 28 Juillet 2015 09:38:25
Objet: Re: [pve-devel] [PATCH] add vlan aware bridge ifupdown script v2

> + if [[ $port =~ ^(eth|bond|wlan)[0-9]{1,2}$ ]] 

Isn't there a better way to do this? 
Like checking the interface type via /proc? Because otherwise we end up 
with more threads like: 
<http://forum.proxmox.com/threads/22504-Unable-to-see-Infiniband-interfaces-in-Proxmox> 

Restricting interfaces to names has always been problematic. 
We already have a problem when someone installes pve packages from a 
normal debian distribution after enabling systemd's interface naming 
scheme.