[pve-devel] [RFC v2] Use JSONSchema to parse vzdump config

Wolfgang Bumiller w.bumiller at proxmox.com
Mon Jul 27 11:42:57 CEST 2015


> -    my $res = {
> +    my $defaults = {
(...)
> +    foreach my $key (keys %$defaults) {
> +	$res->{$key} = $defaults->{$key} if !$res->{$key};
> +    }

I wonder if this is actually even necessary as parse_config should
simply override old keys.

> +	local $/ = undef;

The `= undef;` part shouldn't be necessary as that's implicit. We seem
to mostly leave it out in our code as far as I can tell.




More information about the pve-devel mailing list