[pve-devel] [PATCH] vzdump : abord backup if disk have iothread enabled.

Alexandre Derumier aderumier at odiso.com
Tue Jul 21 15:14:36 CEST 2015


Currently backup don't work with iothread feature, and crash qemu

For now, abord the backup if one of the vm drives have iothread enabled until backup code is fixed.

Upstream qemu backup cde already support iothread.
http://git.qemu.org/?p=qemu.git;a=commit;h=761731b1805f6ef64eb615e5b82a0801db3cde78

Signed-off-by: Alexandre Derumier <aderumier at odiso.com>
---
 PVE/VZDump/QemuServer.pm | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/PVE/VZDump/QemuServer.pm b/PVE/VZDump/QemuServer.pm
index 314538f..64146e8 100644
--- a/PVE/VZDump/QemuServer.pm
+++ b/PVE/VZDump/QemuServer.pm
@@ -67,6 +67,8 @@ sub prepare {
 	if (defined($drive->{backup}) && $drive->{backup} eq "no") {
 	    $self->loginfo("exclude disk '$ds' (backup=no)");
 	    return;
+	} elsif (defined($drive->{iothread}) && $drive->{iothread} eq "on") {
+	    die "disk '$ds' (iothread=on) can't use backup feature currently. Please set backup=no for this drive";
 	}
 
 	my $volid = $drive->{file};
-- 
2.1.4



More information about the pve-devel mailing list