[pve-devel] [PATCH] Implements ZFSLocalPlugin.pm to use Zfs with volumes locally. You can snapshot on the volumes but only in a linear way.

Dietmar Maurer dietmar at proxmox.com
Thu Jan 22 07:05:34 CET 2015


I think we should name the plugin 'ZFSDirPlugin' (type 'zfsdir').

Besides, this is mostly a copy of code from ZFSPlugin, but it is totally 
unclear what you have changed.
If you copy and modify existing code, those action must be visible in 
the patch history.

Also, the code contains many useless and dangerous eval{} wrappers:

+    eval {
+	$text = zfs_request($scfg, undef, 'get', '-o', 'value', '-Hp','available,used', $scfg->{pool});
+    };
+    warn $@ if $@;

What for?







More information about the pve-devel mailing list