[pve-devel] pve-manager : pending patches series v7

[Alexandre DERUMIER]

>>I also have notice a rendering bug in pve-manager,
>>
>>for bollean value,
>>
>>when pending value = 0 , and current default value = 1

I have send a qemu-server patch for this, the bug was in pending api

----- Mail original -----
De: "aderumier" <aderumier at odiso.com>
À: "dietmar" <dietmar at proxmox.com>
Cc: "pve-devel" <pve-devel at pve.proxmox.com>
Envoyé: Lundi 12 Janvier 2015 08:20:45
Objet: Re: [pve-devel] pve-manager : pending patches series v7

>>sigh - sure, should be something like: 
>> 
>>my $old_balloon_enabled = !!(!defined($conf->{balloon}) || 
>>$conf->{balloon}); 
>>my $new_balloon_enabled = !!(!defined($conf->{pending}->{balloon}) || 
>>$conf->{pending}->{balloon}); 


Yes,it's working with this code. 





I also have notice a rendering bug in pve-manager, 

for bollean value, 

when pending value = 0 , and current default value = 1 


[pending] 
acpi:0 
kvm:0 


It's displaying "no", it should display 

yes 
no (red) 





----- Mail original ----- 
De: "dietmar" <dietmar at proxmox.com> 
À: "aderumier" <aderumier at odiso.com> 
Cc: "pve-devel" <pve-devel at pve.proxmox.com> 
Envoyé: Samedi 10 Janvier 2015 20:28:35 
Objet: Re: [pve-devel] pve-manager : pending patches series v7 

> you can have 
> balloon: 100 
> 
> then 
> qm set balloon 200 
> 
> 
> 100 != 200, but it's hotpluggable. 

sigh - sure, should be something like: 

my $old_balloon_enabled = !!(!defined($conf->{balloon}) || 
$conf->{balloon}); 
my $new_balloon_enabled = !!(!defined($conf->{pending}->{balloon}) || 
$conf->{pending}->{balloon}); 

_______________________________________________ 
pve-devel mailing list 
pve-devel at pve.proxmox.com 
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel