[pve-devel] [PATCH 3/7] resize disk : allow resize pending disk

Alexandre DERUMIER aderumier at odiso.com
Thu Jan 1 09:45:10 CET 2015


>>Code gets really complex and clumsy if we implement such things. It that really 
>>required? Why? 

It's only require if we want to resize a pending disk.

>>My plan is to turn on 'hotplug' by default, so that code will (almost) never 
>>trigger? 

We can simply block the feature in the gui, I personnaly don't need to resize a pending disk.

(I have already block the move disk feature for pending disks)




----- Mail original -----
De: "dietmar" <dietmar at proxmox.com>
À: "aderumier" <aderumier at odiso.com>, "pve-devel" <pve-devel at pve.proxmox.com>
Envoyé: Mercredi 31 Décembre 2014 18:01:08
Objet: Re: [pve-devel] [PATCH 3/7] resize disk : allow resize pending disk

> - die "disk '$disk' does not exist\n" if !$conf->{$disk}; 
> + die "disk '$disk' does not exist\n" if !$conf->{$disk} && 
> !$conf->{pending}->{$disk}; 
> + 
> + my $drive = undef; 

Code gets really complex and clumsy if we implement such things. It that really 
required? Why? 

My plan is to turn on 'hotplug' by default, so that code will (almost) never 
trigger? 



More information about the pve-devel mailing list