[pve-devel] [PATCH pve-manager 2/2] Add new commands for zfs, network, lxc

Dietmar Maurer dietmar at proxmox.com
Mon Dec 7 12:29:18 CET 2015


That looks a bit too much for me - is all that required?

> -my @net = ('ifconfig', 'cat /etc/network/interfaces', sub {
> dir2text('/etc/pve/firewall/', '.*fw') },
> -  'iptables-save');
> +my @net = ('ifconfig',
> +  'cat /etc/network/interfaces',
> +  sub { dir2text('/etc/pve/firewall/', '.*fw') },
> +  'iptables-save',
> +  'iptables-save',

2 times?

> +  'ip addr show',
> +  'bridge -c vlan show',
> +  'ip route show',
> +  'ip -6 route show',
> +  'ip neigh show',
> +  'ip neigh show proxy',
> +  'sysctl net.bridge',
> +  'sysctl net.ipv4',
> +  'sysctl net.ipv6'
> +);



More information about the pve-devel mailing list