[pve-devel] Blacklisting HP hardware watchdog timer module ?

[Alexandre DERUMIER]

I'll test this afternoon.

Also, maybe you could add a fallback to softdog, if the modprobe of defined watchdog module is not working ? (wrong module for example)


     if (stat(WATCHDOG_DEV, &fs) == -1) {
-        system("modprobe -q softdog"); // load softdog by default
+        char *wd_module = getenv("WATCHDOG_MODULE");
+        if (wd_module) {
+            char *cmd = NULL;
+            if ((asprintf(&cmd, "modprobe -q %s", wd_module) == -1)) {
+                perror("assemble modprobe command failed");
+                exit(EXIT_FAILURE);
+            }
+            system(cmd);
++           if (stat(WATCHDOG_DEV, &fs) == -1) {
++                system("modprobe -q softdog"); // fallback
++            }
+        } else {
+            system("modprobe -q softdog"); // load softdog by default
+        }
     }
 



----- Mail original -----
De: "dietmar" <dietmar at proxmox.com>
À: "aderumier" <aderumier at odiso.com>
Cc: "pve-devel" <pve-devel at pve.proxmox.com>
Envoyé: Jeudi 3 Décembre 2015 11:16:48
Objet: Re: [pve-devel] Blacklisting HP hardware watchdog timer module ?

> On December 3, 2015 at 10:25 AM Alexandre DERUMIER <aderumier at odiso.com> 
> wrote: 
> 
> 
> >>which do the modprobe to load the module? 
> 
> yes, it should work. (modprobe module is working for me) 

Please can you test? 

https://git.proxmox.com/?p=pve-ha-manager.git;a=commitdiff;h=6263c81dfe8bf78c1f47ab8a1e33aa896202dba0