[pve-devel] [PATCH 1/3] Remove mountpoint dir from vzdump backup

Wolfgang Link w.link at proxmox.com
Wed Aug 26 07:22:33 CEST 2015


Because we have to delete a tree and not only a dir.
and rmtree are the old function and shouldn't use anymore.

http://perldoc.perl.org/File/Path.html

On 08/26/2015 06:15 AM, Dietmar Maurer wrote:
>
>
> On 08/25/2015 01:24 PM, Wolfgang Link wrote:
>> ---
>>   src/PVE/VZDump/LXC.pm | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/src/PVE/VZDump/LXC.pm b/src/PVE/VZDump/LXC.pm
>> index 112bc84..eb43807 100644
>> --- a/src/PVE/VZDump/LXC.pm
>> +++ b/src/PVE/VZDump/LXC.pm
>> @@ -277,6 +277,7 @@ sub cleanup {
>>       # We use -d to automatically free used loop devices
>>       sleep(1);
>>       $self->cmd_noerr("umount -d $di->{mountpoint}");
>> +    File::Path::remove_tree($di->{mountpoint});
>>
>
> Why do you use remove_tree (instead of rmdir)?





More information about the pve-devel mailing list