[pve-devel] pve-container : make create_rootfs sub generic v2

[Alexandre DERUMIER]

>>thanks for the rework, it looks much better now! I applied all patches, 
>>and added a small cleanup on top: 

>>hope that works for you? 

Sure, I forgot to remove $ms.

Thanks for your time to review and comments.


----- Mail original -----
De: "dietmar" <dietmar at proxmox.com>
À: "aderumier" <aderumier at odiso.com>, "pve-devel" <pve-devel at pve.proxmox.com>
Envoyé: Vendredi 21 Août 2015 17:36:50
Objet: Re: [pve-devel] pve-container : make create_rootfs sub generic v2

Hi Alexandre, 

thanks for the rework, it looks much better now! I applied all patches, 
and added a small cleanup on top: 

https://git.proxmox.com/?p=pve-container.git;a=commitdiff;h=1e8f01bedb3fc4f8a3dfd0eff5e8d0d8474798aa 

hope that works for you? 

> On August 21, 2015 at 5:10 PM Alexandre Derumier <aderumier at odiso.com> wrote: 
> 
> 
> This is a rework of my today patch serie 
> 
> - I have added speficic sub for attach|dettach loops. 
> - I now use PVE::Storage::activate_volumes($vollist) in hooks 
> - I don't return loop:/ path anymore in volid_path sub. 
> It's only use in 1 place, for update_config. 
> All other places (backup,create,...) need the real path. 
> Also, this avoid the need to use $ms, which is related to mountpoint and not 
> volid. 
> 
> - create_roofs is generic, next step will to add support to allocate any 
> mounpoint disk 
> 
> _______________________________________________ 
> pve-devel mailing list 
> pve-devel at pve.proxmox.com 
> http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel 
>