[pve-devel] [PATCH 2/5] add mountpoint_activate sub

[Alexandre DERUMIER]

>>For me, activate_volumes is not really related to loop device setup. In future, 
>>this whole loop device setup can be done by lxc (like rootfs). 
>>So I would like to keep that code separate ... 

Ok.

I'll try to rework my patches.


----- Mail original -----
De: "dietmar" <dietmar at proxmox.com>
À: "aderumier" <aderumier at odiso.com>
Cc: "pve-devel" <pve-devel at pve.proxmox.com>
Envoyé: Vendredi 21 Août 2015 12:19:18
Objet: Re: [pve-devel] [PATCH 2/5] add mountpoint_activate sub

> I wonder if I could move the losetup code into PVE::Storage::activate_volumes 
> ? 
> (with an extra flag to enable/disable it) 
> 
> Seem to be the right place ? 

For me, activate_volumes is not really related to loop device setup. In future, 
this whole loop device setup can be done by lxc (like rootfs). 
So I would like to keep that code separate ...