[pve-devel] [PATCH 2/5] add mountpoint_activate sub

[Alexandre DERUMIER]

>>Sorry, I am a bit lost - what is the purpose? It would help If you tell
>>the final goal. Or what is the problem with current code? It is not always
>>obvious ...


Currently, I'm trying to have something generic in create_rootfs (this is my last patch from the serie),
and try to remove as much as possible all the speficic "if storage is rbd,drbd,zfs , if format=raw,subvol ,....)
Later I'll change create_rootfs to something more generic to handle multiple volid, for restore by example.

and try to activate volume + losetup in 1 sub (and remove losetup from Vzdump::LXC, PVE::LXC::Create, PVE::LXC, ...)







----- Mail original -----
De: "dietmar" <dietmar at proxmox.com>
À: "aderumier" <aderumier at odiso.com>
Cc: "pve-devel" <pve-devel at pve.proxmox.com>
Envoyé: Vendredi 21 Août 2015 11:42:59
Objet: Re: [pve-devel] [PATCH 2/5] add mountpoint_activate sub

> I wonder if I could move the losetup code into PVE::Storage::activate_volumes 
> ? 
> (with an extra flag to enable/disable it) 
> 
> Seem to be the right place ? 

Sorry, I am a bit lost - what is the purpose? It would help If you tell 
the final goal. Or what is the problem with current code? It is not always 
obvious ...