[pve-devel] [PATCH v2 3/3] Declare data object in one statement when we want to delete a parameter

Dietmar Maurer dietmar at proxmox.com
Wed Aug 19 09:24:13 CEST 2015


> > > -    deleteEmpty: true,
> > > +    deleteWhenEmpty: true,
> >why do you rename?
> To make the meaning  clearer ? 
> We return a data object containing a *delete* property, *when* the string
> received by the ComboBox is *empty*

But at this stage it only adds confusion, because we still have code with
deleteEmpty...

> 
> >Why don't you use a config property?
> The idea is to use the config property only for parameters which are
> mandatory.

What is the idea behind that? Why only for mandatory parameters?




More information about the pve-devel mailing list