[pve-devel] [PATCH 2/2] ext5migrate: move setting the Panel title into the class properties

Emmanuel Kasper e.kasper at proxmox.com
Tue Aug 18 14:43:33 CEST 2015


Ext.applyIf(me, {
	    title: gettext('Search')
});
in initComponent() is not safe anymore with ExtJS5.
Since the 'title' property is existing at that stage (even if with a null or undefined value), Ext.applyIf will not update it.
---
 www/manager5/grid/ResourceGrid.js | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/www/manager5/grid/ResourceGrid.js b/www/manager5/grid/ResourceGrid.js
index 3dfbc45..e638ec1 100644
--- a/www/manager5/grid/ResourceGrid.js
+++ b/www/manager5/grid/ResourceGrid.js
@@ -5,6 +5,8 @@ Ext.define('PVE.grid.ResourceGrid', {
     //fixme: this makes still problems with the scrollbar
     //features: [ {ftype: 'chunking'}],
     
+    title: gettext('Search'),
+
     initComponent : function() {
 	var me = this;
 
@@ -148,10 +150,6 @@ Ext.define('PVE.grid.ResourceGrid', {
 	    updateGrid(); 
 	};
 
-	Ext.applyIf(me, {
-	    title: gettext('Search')
-	});
-
 	Ext.apply(me, {
 	    store: store,
 	    tbar: [
-- 
2.1.4





More information about the pve-devel mailing list