[pve-devel] qemu-server : allow only hotpluggable|dynamics options to be change online

[Alexandre DERUMIER]

>>Just have a look at my one 
This is the last version : ?
http://pve.proxmox.com/pipermail/pve-devel/2014-July/012003.html

>>I think i check a lot more cases than yours ;-) 

I read fastly your code, I think I handle all the same values.

Only difference is that I do it early, checking all params before trying to apply them really.

I have tested all options through gui, and all seem to works fine.



@Dietmar, do you have some comments about theses patches ?
I don't known if you are ok with  disallow online change of non hotpluggable values.



----- Mail original ----- 

De: "Stefan Priebe - Profihost AG" <s.priebe at profihost.ag> 
À: "Alexandre DERUMIER" <aderumier at odiso.com> 
Cc: pve-devel at pve.proxmox.com 
Envoyé: Vendredi 5 Septembre 2014 09:44:01 
Objet: Re: [pve-devel] qemu-server : allow only hotpluggable|dynamics options to be change online 

Am 04.09.2014 um 16:16 schrieb Alexandre DERUMIER: 
>>> Did you see my patches posted earlier this year? I already did the same. 
>>> 
>>> I can post also an up2date version. 
> 
> yes, sure, resend your patch. I would like to compare :) 
> 
> (I think I'm doing it early than, before going into the main loop). 
> 
>>> There are some corner cases. Like mem with virtio. 
> Oh, don't known about it. What's this problem exactly ? 

I think i check a lot more cases than yours ;-) 

Just have a look at my one 

Subject: [PATCH] check for valid config changes 

Stefan 


> ----- Mail original ----- 
> 
> De: "Stefan Priebe - Profihost AG" <s.priebe at profihost.ag> 
> À: "Alexandre Derumier" <aderumier at odiso.com> 
> Cc: pve-devel at pve.proxmox.com 
> Envoyé: Jeudi 4 Septembre 2014 16:06:45 
> Objet: Re: [pve-devel] qemu-server : allow only hotpluggable|dynamics options to be change online 
> 
> 
> Did you see my patches posted earlier this year? I already did the same. 
> 
> 
> I can post also an up2date version. There are some corner cases. Like mem with virtio. 
> 
> Stefan 
> 
> 
> Excuse my typo s ent from my mobile phone. 
> 
> Am 04.09.2014 um 15:50 schrieb Alexandre Derumier < aderumier at odiso.com >: 
> 
> 
> 
> 
> Hi, 
> 
> This is a first try for filtering options change of running vms. 
> 
> Only hotplugable values (disk,nic,cpu), dynamics values (disk throttle, cdrom media change,balloon,..), 
> and some options (name,onboot,...) 
> are allowed. 
> 
> The main idea is to always have a config which is the same than running qemu guest. 
> 
> This help to avoid hanging live migration, if config have changed but qemu process not yet restarted. 
> This also avoid confusion for users (need to stop/start after config change) 
> and also helping with hotplugging to be sure that we have a config equal to current qemu disk/controllers. 
> 
> I'm also thinking to improve pve-manager to grey-out non modifiable values when vm is running. 
> 
> review and comments are welcome ! 
> 
> 
> 
> _______________________________________________ 
> pve-devel mailing list 
> pve-devel at pve.proxmox.com 
> http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel 
>