[pve-devel] qemu-server : implement pending changes v2

[Cesar Peschiera]

Oh, currently, ok, sorry, I did not understand very well

> Another way could be to add a button to apply manually the pending change.
> (Don't known what is the best way)

IMHO, i believe that the behavior must be similar to the changes of network
on the PVE GUI, ie, with the notices of stop/start necessaries

Best regards
Cesar Peschiera


----- Original Message ----- 
From: "Alexandre DERUMIER" <aderumier at odiso.com>
To: "Cesar Peschiera" <brain at click.com.py>
Cc: <pve-devel at pve.proxmox.com>
Sent: Friday, October 31, 2014 1:33 AM
Subject: Re: [pve-devel] qemu-server : implement pending changes v2


>>Is possible that the change a non-hotpluggage value also be migrated with
>>the VM?

a non-hotpluggage value is in pending until restart, so when a vm is
migrated is keep in pending.



Currently, the behaviour is bad, if you add a disk without hotplug, it's
registered in vm config file.
Then if you migrate, the target vm will be started with the disk attached,
but the memory copy of the source vm don't have any
reference to this disk, so the migrate will crash at the end.



----- Mail original ----- 

De: "Cesar Peschiera" <brain at click.com.py>
À: "Alexandre DERUMIER" <aderumier at odiso.com>
Cc: pve-devel at pve.proxmox.com
Envoyé: Jeudi 30 Octobre 2014 23:59:12
Objet: Re: [pve-devel] qemu-server : implement pending changes v2

Hi

I have a question, please see below

----- Original Message ----- 
From: "Alexandre DERUMIER" <aderumier at odiso.com>
To: "Stanislav German-Evtushenko" <ginermail at gmail.com>
Cc: <pve-devel at pve.proxmox.com>
Sent: Thursday, October 30, 2014 1:32 PM
Subject: Re: [pve-devel] qemu-server : implement pending changes v2


>>>Some questions regarding this patch:
>>>- What happens when we do online migration with pending changes?
>
> pending changes not applied.
> (Currently if you do a change a non-hotpluggage value and you do a live
> migration, you have good chance to crash)
>
.... :-(
Is possible that the change a non-hotpluggage value also be migrated with
the VM?

Best regards
Cesar Peschiera